test: simplify visual tests to not use import.meta #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
test/simplify-visual-tests
branch
from
28bb236 to
626b39b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Sep 11, 2021
|
This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to modernweb-dev/web#1657, there is no need to use
import.metaanymore 🎉Note
Changes are done using the following regular expressions:
Tests without interpolations
RegExp
/`\$\{import\.meta\.url\}_([a-z\-]+)`/Before
`${import.meta.url}_basic`After
'basic'Tests with interpolations
RegExp
`\$\{import\.meta\.url\}_([a-z\-\{\}\$]+)`Before
`${import.meta.url}_${dir}-align-left`After
`${dir}-align-left`Type of change