proxy dns with NOTIMP error #2954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here is similar issue XTLS/Xray-core#3006.
|
Contributor
|
It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
|
I think it would be better if we guard this new behavior behind a flag or option, otherwise it would take significantly longer time decide if a regression is justified. |
xiaokangwang
added
the
Extensive Review Required
Contributor
Author
|
@xiaokangwang Please approve GitHub actions on this PR. |
Contributor
|
Sadly I didn't see a place where I can approve it. Let's me have a try... Done. |
Contributor
|
It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days |
``` $ go generate ... proto.go fork/exec ../Cellar/protobuf/28.3/bin/protoc: no such file or directory exit status 1 proto.go:5: running "go": exit status 1 context_test.go functions_test.go v2ray_test.go $ ls -l `which protoc` lrwxr-xr-x 1 local admin 34 Nov 1 13:56 /opt/homebrew/bin/protoc -> ../Cellar/protobuf/28.3/bin/protoc ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium will send SVCB/HTTPS type dns query, which cause dns leak.
To prvent dns leak,