fix multiarch buildah command #2943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up fix for #2757 😳
It seems the newly published images are single-arch. Went through a few manuals and it turned out that we should use
--manifestinstead of--tag.Also
buildahdoesn't supports more than one--manifestarguments in one build, so we have to build each (v5,v5.15,v5.15.0, etc) separately even if they are identical images/manifests.Ideally we can move
downloadAssets.sh's logic into Containerfile itself so we can build for multiple archs concurrently. However that would be a big change and I'd rather leave it as is for now.