Skip to content

Conversation

@AkinoKaede
Copy link
Contributor

resolve #1026

@AkinoKaede AkinoKaede marked this pull request as draft May 26, 2021 04:55
@AkinoKaede AkinoKaede marked this pull request as ready for review July 16, 2021 14:49
@AkinoKaede AkinoKaede force-pushed the feat-grpc-x-forwarded-for branch from 8da9c79 to b471872 Compare July 16, 2021 14:54
@AkinoKaede AkinoKaede force-pushed the feat-grpc-x-forwarded-for branch from b471872 to 89ff515 Compare July 16, 2021 14:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #1032 (89ff515) into master (8fed55f) will increase coverage by 0.08%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   44.73%   44.82%   +0.08%     
==========================================
  Files         485      486       +1     
  Lines       29490    29505      +15     
==========================================
+ Hits        13193    13226      +33     
+ Misses      14890    14878      -12     
+ Partials     1407     1401       -6     
Impacted Files Coverage Δ
transport/internet/grpc/encoding/conn.go 0.00% <0.00%> (ø)
common/protocol/grpc/metadata.go 77.77% <77.77%> (ø)
transport/internet/kcp/connection.go 72.92% <0.00%> (+1.10%) ⬆️
proxy/freedom/freedom.go 49.00% <0.00%> (+4.00%) ⬆️
common/buf/reader.go 88.23% <0.00%> (+5.88%) ⬆️
transport/internet/udp/dispatcher.go 77.14% <0.00%> (+12.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fed55f...89ff515. Read the comment docs.

@kslr
Copy link
Contributor

kslr commented Jul 17, 2021

我认为使用最后一个是合理的

@AkinoKaede
Copy link
Contributor Author

我认为使用最后一个是合理的

是的,不过我觉得应该和 WebSocket 和 HTTP/2 保持一致,或者统一修改。

@github-actions
Copy link
Contributor

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 19, 2022
@AkinoKaede AkinoKaede closed this Feb 19, 2022
@kslr kslr reopened this Feb 21, 2022
@AkinoKaede AkinoKaede changed the base branch from dev-v4main to master February 21, 2022 14:19
@github-actions github-actions bot closed this Feb 27, 2022
ttrobot0101 pushed a commit to ttrobot0101/v2ray-core that referenced this pull request Aug 17, 2025
ci(release_feat_v5.yml): update
@hann-wang
Copy link

LGTM

@xiaokangwang Is there any concern for this PR?

hann-wang pushed a commit to hann-wang/v2ray-core that referenced this pull request Jan 23, 2026
@AkinoKaede AkinoKaede reopened this Jan 30, 2026
@github-actions github-actions bot removed the Stale label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] grpc 不接受来自 X-Real-IP 的 ip 作为客户端 ip

4 participants