Skip to content

Conversation

@MkQtS
Copy link
Contributor

@MkQtS MkQtS commented Feb 10, 2026

They are part of Chinese entities but exclusively serving for non-cn area

As #3198 moved them out from category-xxx-cn/geolocation-cn, this adds them into category-xxx-!cn/geolocation-!cn

If there's no objection, I'll merge this in a week

They are part of Chinese entities but **exclusively** serving for non-cn area

This is a continuation of #3198
@nekolsd
Copy link
Contributor

nekolsd commented Feb 10, 2026

What are we doing here bro, the category-companies list states that

This list contains Tech & Cyber companies and organizations outside China mainland.

Adding domains of China mainland-based companies that serve non-cn area into this list doesn't make sense. These domains still belong to Chinese companies, not foreign ones — this contradicts the list's own description and makes the categorization misleading.

This probably goes back to how the project categorized things in the first place — some lists may have been poorly named from the start. But that's not a reason to make it worse by adding more mismatched entries.

don't do this bro

@MkQtS
Copy link
Contributor Author

MkQtS commented Feb 10, 2026

Adding domains of China mainland-based companies that serve non-cn area into this list doesn't make sense

Well, I thought these domains are used by their foreign subsidiary which may considered as non-cn companies. geolocation-!cn is a bit too generic, and these lists match the Tech & Cyber companies topic, so I added them to category-companies.

I can add them directly in geolocation-!cn, or create a new list like category-non-domestic-cn-companies(the name may be shorter...). That's not a problem.

Beyond this naming/categorization detail, actually, I am more concerned about whether this change is reasonable/necessary. I think removing @!cn domain rules out from category-xxx-cn is quite reasonable. But after this, I found the change appears to diminish the value of these removed domains(originally cn@!cn domains) as they were removed from big categories but not added to new ones. I had a feeling that since I was the one who drove them away, it should be my responsibility to find them a place to go. So it may be a choice to add them into geolocation-!cn families.

TBH, I don't like the idea to add all @cn domains to geolocation-cn and all @!cn to geolocation-!cn. It doesn't make sense to treat google@cn domains as part of cn domains. Similarly, I'm puzzled about the necessity of adding cn@!cn into -!cn lists.

Do you have any suggestions about that? Feel free to share your ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants