fix: Discover MSVC include paths for Windows bindgen builds #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bindgen compilation error on Windows MSVC with GPU features: 'stdbool.h' file not found in ggml.h:207 Root cause: bindgen's libclang cannot find MSVC standard C headers (stdbool.h, stddef.h, etc.) without explicit -isystem paths. Solution: - Use cc::Build to discover MSVC environment and extract INCLUDE paths - Pass each path via -isystem to bindgen's clang - Add MSVC compatibility flags (--target, -fms-compatibility, -fms-extensions) Pattern follows existing Android fix at lines 390-414. Enables Windows MSVC builds with GPU backends (cuda/vulkan/opencl). Tested in production with shimmy v1.6.0 (295/295 tests passing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bindgen compilation error on Windows MSVC with GPU features: 'stdbool.h' file not found in ggml.h:207
Root cause: bindgen's libclang cannot find MSVC standard C headers (stdbool.h, stddef.h, etc.) without explicit -isystem paths.
Solution:
Pattern follows existing Android fix at lines 390-414.
Enables Windows MSVC builds with GPU backends (cuda/vulkan/opencl). Tested in production with shimmy v1.6.0 (295/295 tests passing).