Add StopMedia method to ScreenDevice#18
Open
habibrehmansg wants to merge 1 commit intousausa:mainfrom
Open
Conversation
Introduce StopMedia() to ScreenDevice to send command 111 and invoke RequestResponse(), returning a boolean success indicator. This adds a simple API to stop media playback from the device by preparing the command header and issuing the request.
Contributor
Author
|
Hi! Thanks for reviewing this PR. I've been working with the Turing USB protocol (rev 1.1) and have identified several additional commands that the device supports beyond what's currently in Storage management:
Media playback:
Settings:
These have been validated against working implementations. Happy to contribute them if they'd be a good fit for this library. |
Owner
|
I welcome pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce StopMedia() to ScreenDevice to send command 111 and invoke RequestResponse(), returning a boolean success indicator. This adds a simple API to stop media playback from the device by preparing the command header and issuing the request.
Sending JPEG to a device that may be having a media playback will result in flickering. PNG overlays transparency properly do it does not have this issue, but JPEG is superior in term of frame rate (~3x).