This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Added the --stack-evolution option
#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bok-
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would enable Library Evolution (eg.
BUILD_LIBRARY_FOR_DISTRIBUTION=YES) only on the targets that were specified on the command line. This is to work around issues with dependencies like swift-nio that have annotations for library evolution, but that cannot be compiled with evolution enabled, and have no plans to support it anytime soon.This is can be inefficient though as it means fiddling with the targets list in order to enable library evolution when you do need it turned on for dependencies as well (eg. you can't build an XCFramework if you depend on SwiftProtobuf because library evolution also raises the minimum supported platform versions).
The new option added in this PR,
--stack-evolution, helps by turning onBUILD_LIBRARY_FOR_DISTRIBUTION=YESfor the entire build stack instead of just the specified targets.