Conversation
…r improved readability
Y0me
changed the title
commit: |
cyyynthia
left a comment
cyyynthia
left a comment
There was a problem hiding this comment.
Disclaimer: I'm not a maintainer and don't speak on behalf of the Reka maintainers or the unovue team 😅
| * @param vnode - An Element or Vue ComponentPublicInstance, or null. | ||
| * @returns The corresponding HTMLElement if available, otherwise undefined. | ||
| */ | ||
| export function getHTMLElementFromVNode(vnode: Element | ComponentPublicInstance | null): HTMLElement | undefined { |
There was a problem hiding this comment.
Since Reka already heavily leverages vueuse it might be a good idea to rely on their helpers instead, which are compatible with SVG elements
There was a problem hiding this comment.
Will look into that this week
| :ref="(node: ComponentPublicInstance) => { | ||
| headFocusProxyRef = unrefElement(node) as HTMLElement | ||
| return undefined | ||
| :ref="(node) => { |
There was a problem hiding this comment.
Not sure how to feel about these refs; would perhaps be better to keep the raw ref and unwrap when needed..? 🤔
There was a problem hiding this comment.
Moving the handlers out of the template is a good idea imho, perhaps it'd be a good idea to also do this change in other files? 🤔
There was a problem hiding this comment.
Yep, wanting to do that for other files too... But motivation at this time of day was falling apart. 😅
2 participants
This PR begins addressing #2043 (opened by @cyyynthia) by upgrading to Vue Language Services v3 and starting to resolve the typing issues it surfaces.
What’s inside :
Notes :
This is still a WIP — I haven’t had time to fully test everything yet. Most changes are small and localized, but I’d really appreciate feedback and a fresh pair of eyes to help bring this across the finish line.