fix(dashboard): scrollbar gutter gap and loading state overflow#6189
Draft
dave-hawkins wants to merge 1 commit into
Draft
fix(dashboard): scrollbar gutter gap and loading state overflow#6189dave-hawkins wants to merge 1 commit into
dave-hawkins wants to merge 1 commit into
Conversation
Remove scrollbar-gutter: stable from the content pane; it reserved a permanent gutter, showing as a gap on routes without a scrollbar. Size LoadingState with flex-1 instead of h-dvh so it fills its container rather than the viewport. As a Suspense fallback inside the content pane it was 100dvh tall in a shorter pane, flashing a scrollbar on load. The standalone usage in (app)/layout is wrapped in an h-dvh container so it still fills the screen there.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two scrollbar glitches in the dashboard app shell.
scrollbar-gutter: stableon the main content pane created a permanent gutter on every route, which showed as an empty gap down the right side of pages that don't scroll:LoadingStatewash-dvh(full viewport height) but is used as a Suspense fallback inside the content pane, which is shorter than the viewport — so on page load the fallback overflowed the pane and flashed a vertical scrollbar before the real content swapped in.Type of change
Screenshots
Before:
After:
yay - no space!
How should this be tested?
/projectswith few projects), confirm there's no empty gap on the right edge of the content area.Verified in-browser by measurement: the old
h-dvhfallback rendered 665px tall inside a 613px content pane (overflow → scrollbar); the newflex-1fallback fills the pane exactly (no scrollbar) and keeps the spinner centered. The load-time flash itself was not caught visually — on localhost the Suspense data resolves in under a frame — so the before/after here is measurement-based, not a recording.Checklist
Required
pnpm buildpnpm fmtmake fmton/godirectoryconsole.logsgit pull origin mainAppreciated