[ibis 🦩] remove inplace=True in column validate call #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
deepyaman
approved these changes
Jul 6, 2025
Collaborator
deepyaman
left a comment
deepyaman
left a comment
There was a problem hiding this comment.
That makes sense! Yes, it probably didn't manifest in any way before, because I hadn't added the warning for inplace until a PR or two ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deepyaman the
inplace=Trueargument may have been copy-pasted from a different pandera backend implementation? In the column component schemainplace=Trueissues a warning that it'll have no effect.