Implement regex option and add additional checks
#2061
Conversation
deepyaman
changed the title
regex option and add additional checksregex option and add additional checks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
- Coverage 94.28% 93.51% -0.77%
==========================================
Files 91 135 +44
Lines 7013 10481 +3468
==========================================
+ Hits 6612 9801 +3189
- Misses 401 680 +279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepyaman
force-pushed
the
feat/ibis/regex
branch
from
03f9538 to
ae05826
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/regex
branch
from
ae05826 to
68defb1
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
| ], | ||
| [ | ||
| lambda t, col: t.mutate(**{col: _failure_value(col)}), | ||
| "Column '.+' failed element-wise validator number", |
There was a problem hiding this comment.
The Polars error message doesn't contain "element-wise"; see tests/polars/test_polars_container.py.
deepyaman
changed the title
regex option and add additional checksregex option and add additional checks
|
@cosmicBboy 49cee21 feels like a more significant change that you may want to check; it feels a bit hacky, but it's also similar in spirit to what's done on the pandas/PySpark backends I think. If you're not comfortable with it, can remove it to a separate PR for now and have somewhat less complete regex support. |
2 participants
Should be merged after #2063