Test column presence, mark other features not impl #2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 94.28% 93.48% -0.80%
==========================================
Files 91 135 +44
Lines 7013 10451 +3438
==========================================
+ Hits 6612 9770 +3158
- Misses 401 681 +280 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepyaman
commented
Jun 28, 2025
| def coerce(self, data_container: Any): | ||
| """Coerce data container to the data type.""" | ||
| raise NotImplementedError() | ||
| raise NotImplementedError |
Collaborator
Author
There was a problem hiding this comment.
Inspired by https://docs.astral.sh/ruff/rules/unnecessary-paren-on-raise-exception/, but I can back it out and/or do it in a separate PR if preferred
cosmicBboy
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.