[🦩 ibis] Limit reported failure cases if Check.n_failure_cases is defined. #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
…is defined Signed-off-by: cosmicBboy <[email protected]>
deepyaman
approved these changes
Jun 26, 2025
Collaborator
deepyaman
left a comment
deepyaman
left a comment
There was a problem hiding this comment.
LGTM
Although it also has the Polars changes, not sure if that was intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a parity feature that's available in the pandas backend. Essentially, if Check(..., n_failure_cases=) is specified, the failure cases reported for that check will be limited by