bugfix/2031: Allow strict='filter' and coerce='True' at the same time for PySpark schemas #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…schemas. Generalize test to validate this case. Signed-off-by: Gianluca Filaci <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
- Coverage 94.28% 93.86% -0.42%
==========================================
Files 91 121 +30
Lines 7013 9755 +2742
==========================================
+ Hits 6612 9157 +2545
- Misses 401 598 +197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cosmicBboy
approved these changes
Jul 3, 2025
Collaborator
|
LGTM! and congrats on your first contribution to pandera @gfilaci ! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2031.
The check_obj.pandera.schema attribute is restored after columns are dropped.
The fix is similar to what is done (for example) already here:
https://github.com/unionai-oss/pandera/blob/main/pandera/backends/pyspark/container.py#L455
The modified test would fail without this patch.