fix pyarrow string issue, fix docs failing issues #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2017
This PR addresses a issue where Engine.register_dtype equivalents entries would be overridden due to numpy and pandas behavior where dtypes would evaluate to True if they are equal to the string representation of the dtype, e.g.
np.dtype("int64") == "int64".This led to the mapping of
pyarrow[string] -> pd.StringDtype()to being overridden by pd.ArrowDtype(pyarrow.string()).This PR fixes this by:
Introducing a
StrictEquivalentdataclass to make sure that specific registered datatype equivalents are registered under astrict_equivalentsregistry that keeps track of both the type value and its underlying type so that the problem articulated above doesn't happen.