Skip to content

Conversation

@hendera2
Copy link
Contributor

@hendera2 hendera2 commented Jun 1, 2024

Improvements to make TryPandera documentation more clear and beginner friendly as reported in issue #1629

@codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (812b2a8) to head (70cc8bf).
Report is 148 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1668       +/-   ##
===========================================
- Coverage   94.28%   82.48%   -11.81%     
===========================================
  Files          91      117       +26     
  Lines        7013     8688     +1675     
===========================================
+ Hits         6612     7166      +554     
- Misses        401     1522     +1121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the edits! see nits and comments below

@hendera2
Copy link
Contributor Author

I've updated the line breaks in the whole file to revert to the previous pattern of breaking up longer lines instead of having one single long long without breaks. Please let me know if there are any other specific changes I should address or if I misunderstood something. Thank you!

@cosmicBboy
Copy link
Collaborator

thanks @hendera2, and congrats on your first PR to pandera 🚀

@cosmicBboy cosmicBboy merged commit 35295d3 into unionai-oss:main Jun 26, 2024
max-raphael pushed a commit to max-raphael/pandera that referenced this pull request Jan 24, 2025
* updated trypandera documentation

Signed-off-by: hendera2 <[email protected]>

* updated trypandera documentation

Signed-off-by: hendera2 <[email protected]>

* Fixes to try_pandera.ipynb

Fixes based on pull request comments

* adjustments to try_pandera page

---------

Signed-off-by: hendera2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants