Add unique_values_eq argument to pa.Field
#1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: unionai-oss#1168 `unique_values_eq` missing in `pa.Field` 1. Add `unique_values_eq` argument support to `pa.Field` Signed-off-by: karajan1001 <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 65 65
Lines 5066 5066
=======================================
Hits 4926 4926
Misses 140 140
☔ View full report in Codecov by Sentry. |
cosmicBboy
approved these changes
Jun 22, 2023
Collaborator
|
Thanks for the contribution @karajan1001 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1168
unique_values_eqmissing inpa.Fieldunique_values_eqargument support topa.FieldVerified in my local workspace ,did not find a place to add tests for it.