[UNDERTOW-2609] Fix the meaning of the methods in the exchange that return the query string#1855
Merged
Merged
Conversation
…on decoded query string, and replace all internal usage of this method by the new method, getDecodedQueryString() Signed-off-by: Flavia Rainone <frainone@redhat.com>
… more sense in the nomenclature of query strings: * the method getQueryString() is the new standard for getting the original, unencoded, query string. * the method getNonDecodedQueryString is marked for removal in future release * the method setNonDecodedQueryStirng is replaced by setUnencodedQueryString and marked for removal as well * ProxyHandler uses getQueryString instead of getNonDecodedQueryString Signed-off-by: Flavia Rainone <frainone@redhat.com>
… HttpServerExchange. The nomenclature queryString refers always to unencoded query, whereas decodedQueryString is the decoded counterpart. Notice that this makes the invocation of setQueryString mandatory while parsing requests, while setDecodedQueryString is optional and can be used only when decoding of the query is performed. Signed-off-by: Flavia Rainone <frainone@redhat.com>
…ery string in its entire form instead of the beginning, apply this to AjpParsingUnitTestCase (although the original form of the query string in this case is unreadable) Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
added
waiting CI check
This was referenced Feb 9, 2026
fl4via
removed
the
next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/UNDERTOW-2609
This is a bug fix because the getQueryString reflects in external API methods of Undertow and it is affecting its ability to work with other frameworks.
2.2.x PR: #1882
2.3.x PR: #1860
2.4.x PR: #1894
Undertow EE:
Main: undertow-io/undertow-ee#52
1.0.x: undertow-io/undertow-ee#53