chore: bump unrs-resolver to v1.3.3
#267
Conversation
🦋 Changeset detectedLatest commit: 5bce93f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces several configuration and dependency updates. A new changeset entry documents a patch for the Changes
Sequence Diagram(s)sequenceDiagram
participant PR as "Pull Request Event"
participant GA as "GitHub Actions"
participant Autofix as "Autofix Job"
participant Checkout as "Checkout Repo"
participant Setup as "Setup Node.js"
participant Install as "Install Dependencies"
participant Format as "Format Code"
participant Fix as "Apply Autofix"
PR->>GA: New PR (open, reopen, synchronize)
GA->>Autofix: Start Autofix job
Autofix->>Checkout: Checkout repository
Autofix->>Setup: Set up Node.js LTS
Autofix->>Install: Run yarn --immutable
Autofix->>Format: Execute yarn format
Autofix->>Fix: Run autofix-ci action
sequenceDiagram
participant Trigger as "Release Trigger"
participant GA as "GitHub Actions"
participant ReleaseJob as "Release Job"
Trigger->>GA: Trigger release workflow
GA->>ReleaseJob: Start release job
ReleaseJob->>ReleaseJob: Check concurrency (cancel outdated runs)
ReleaseJob->>GA: Execute release steps with updated permissions & env variables
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
.simple-git-hooks.mjs(node:16864) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files Oops! Something went wrong! :( ESLint: 9.23.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version of the unrs-resolver package to v1.3.3 and updates related documentation and CI configuration.
- Updated README.md to add sponsor and backer sections
- Modified release workflow to include a new environment variable
- Added a changeset entry for the version bump
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Added sections for sponsors, backers, and references |
| .github/workflows/release.yml | Included NPM_CONFIG_PROVENANCE in the release process |
| .changeset/early-mangos-invite.md | Created a changeset entry for the version bump |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
README.md:621
- [nitpick] The URL uses an unconventional casing ('GitHub.com'). Consider updating it to 'https://github.com/JounQin' to follow standard usage.
[jounqin]: https://GitHub.com/JounQin
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 106 106
Lines 5034 5034
Branches 1778 1779 +1
=======================================
Hits 4842 4842
+ Misses 191 186 -5
- Partials 1 6 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
README.md (3)
592-599: Review of the Sponsors section additionThe new Sponsors section is clearly added with a well-formatted table that includes logos and links. Please verify that the image URL (
https://raw.githubusercontent.com/1stG/static/master/sponsors.svg) is reliable and that the link (https://github.com/sponsors/JounQin) correctly points to the intended sponsor page. Additionally, consider adding descriptive alt text for better accessibility and clarity.
600-605: Review of the Backers section additionThe Backers section follows a similar table layout as the Sponsors section. Ensure that each backer's image (with URLs for 1stG, RxTS, and UnTS) is loading correctly and that the respective Open Collective links are valid. Like the Sponsors section, consider using alt texts for the images to enhance accessibility.
610-623: Review of the License section and link referencesThe License section now clearly displays attribution with a reference to the MIT license. However, the syntax
[MIT][] © [JounQin][]@[1stG.me][]seems a bit unconventional. It might be beneficial to reformat it for better Markdown clarity—for example, by ensuring that each reference is rendered as a proper hyperlink. Also, ensure that all link references (e.g.,[1stg.me],[jounqin],[mit]) are defined correctly later in the file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
.changeset/early-mangos-invite.md(1 hunks).github/workflows/autofix.yml(1 hunks).github/workflows/release.yml(2 hunks).simple-git-hooks.mjs(1 hunks)README.md(1 hunks)package.json(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on windows-latest
🔇 Additional comments (14)
.changeset/early-mangos-invite.md (2)
1-3: Well-Formatted Changeset Entry.
The front matter section with the dashes and the package update line ("eslint-plugin-import-x": patch) is clear and properly structured.
5-6: Clear Dependency Update Note.
The note "chore: bumpunrs-resolverto v1.3.3" explicitly communicates the dependency update. Ensure this change is verified against the updated version inpackage.json..simple-git-hooks.mjs (1)
1-2: Consistent Module Import Style.
The export statement now uses single quotes ('@1stg/simple-git-hooks'), which aligns with the project's style guidelines..github/workflows/release.yml (3)
8-11: Concurrency Block Added.
The introduction of the concurrency block using${{ github.workflow }}-${{ github.ref }}prevents overlapping runs and is a solid addition for workflow efficiency.
12-16: Enhanced Permissions Configuration.
Granting write access forcontents,id-token, andpull-requestsmeets the requirements for release automation. This configuration appears well considered for the release process.
52-53: npm Provenance Environment Variable Set.
AddingNPM_CONFIG_PROVENANCE: trueensures that npm includes provenance information during the release process, which aids in traceability and debugging.package.json (4)
36-36: New Formatting Script Added.
The addition of the"format": "prettier --write ."script provides a convenient way to maintain consistent code style across the codebase—ideal for integration with automated formatting workflows.
63-63: Dependency Version Bumped.
Theunrs-resolverdependency is updated from^1.3.1to^1.3.3. This update should address any issues from the previous version and is properly reflected across the changeset and dependency listings.
98-98: @types/node Version Update.
Upgrading"@types/node"to^20.17.28ensures compatibility with newer Node.js versions.
109-109: eslint-import-resolver-typescript Version Update.
Moving to version^4.3.1should resolve any previous inconsistencies with TypeScript resolution during linting..github/workflows/autofix.yml (3)
1-2: Appropriate Workflow Naming.
Naming the workflow"autofix.ci"satisfies the security requirement and clearly indicates its purpose.
10-13: Effective Concurrency Control.
The concurrency settings ensure that only the latest run for a given pull request executes, which helps prevent redundant or conflicting operations.
14-37: Well-Structured Autofix Workflow.
The job steps (checkout, Node.js setup, install dependencies, format codes, and apply the autofix action) are clear and sequential, aligning perfectly with the PR objectives of automating code formatting.README.md (1)
606-609: Review of the Changelog section additionIntroducing a dedicated Changelog section that directs users to
[CHANGELOG.md](./CHANGELOG.md)is a great improvement for transparency and detailed release notes. Please verify that theCHANGELOG.mdfile exists in the repository and is kept up-to-date with recent changes.
close #266
Summary by CodeRabbit
This release includes updates to the project documentation along with several internal improvements to enhance performance and consistency.