Skip to content

Conversation

madsrasmussen
Copy link
Contributor

Description

These files are a leftover from when a relation type was editable from the UI. They aren't used anywhere but they are unfortunately exported. They are currently under "packages" but aren't set up as a package. I have moved them to the core package until they can be deleted. They have their own import map entry so it won't affect imports.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title move object type files to core Chore: Move object type files to core Aug 8, 2024
@leekelleher leekelleher enabled auto-merge August 8, 2024 16:13
@leekelleher leekelleher self-requested a review August 8, 2024 16:21
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I tested against the wrong branch, (I'd confused with #2195)! 🤦

I'm getting an error locally and on the GitHub actions...

Error: Could not find export: ./object-type -> ./dist-cms/core/object-type/index.js in the build output.

I'm unsure what else needs to be changed, as package.json looks correct to me.

Copy link

@madsrasmussen
Copy link
Contributor Author

madsrasmussen commented Aug 12, 2024

@leekelleher Saved by the validate package script 💯 The path to the object-type module was wrong in package.json. It was missing the /packages/ part.

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested, all builds successfully! 🚀

@leekelleher leekelleher merged commit 18b11ed into main Aug 12, 2024
8 checks passed
@leekelleher leekelleher deleted the v14/chore/move-object-type-to-core branch August 12, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants