Skip to content

Bugfix: Health check icons and colors #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

Bugfix: Health check icons and colors #2158

merged 2 commits into from
Aug 5, 2024

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 31, 2024 •
edited by madsrasmussen
Loading

Description

This PR adjust icons on health check overview to match icon on each health check (mainly the "wrong/error" icon).
Furthermore updated color for "alert/danger" to match icon in overview under <uui-tag> and increase contrast.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

image

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

madsrasmussen
madsrasmussen approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bjarnef

Thanks for the PR. The changes look good! 🥇

@madsrasmussen madsrasmussen merged commit dfca67f into umbraco:main Aug 5, 2024
8 checks passed
@bjarnef bjarnef deleted the feature/health-check-icons branch August 5, 2024 07:13
@madsrasmussen madsrasmussen changed the title Health check icons and colors Bugfix: Health check icons and colors Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
release/14.2.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjarnef @madsrasmussen