Skip to content

Bundling: Templating package #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jul 3, 2024
Merged

Bundling: Templating package #2064

merged 43 commits into from
Jul 3, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jul 1, 2024 •
edited
Loading

Description

See #1977 for more details about the bundling changes.

This PR bundles the Templating Package including all modules.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen
remove unused index.ts
1b9c453
@madsrasmussen
add templating package to workspaces
d20cebe
@madsrasmussen
add package.json
8a80e7f
@madsrasmussen
Create vite.config.ts
c5bb9d4
@madsrasmussen
align file name for menu manifests
ae20f14
@madsrasmussen
remove import
2f42d0f
@madsrasmussen
align folder names
4d09245
@madsrasmussen
remove index
14efc84
@madsrasmussen
rename to local components
97f6f1c
@madsrasmussen
import insert menu where used
ce11b83
@madsrasmussen
lazy load repository
39dfa8e
@madsrasmussen
lazy load apis
2d13066
@madsrasmussen
split token from implementation
34e331b
@madsrasmussen
fix import order
0a3ae4a
@madsrasmussen
add type and remove tsignore
76aeefb
@madsrasmussen
rename to folder global components
3a8ac50
@madsrasmussen
rename folder to global components
ec4bf8e
@madsrasmussen
rename to global components
12a00b5
@madsrasmussen
change import to use alias
69fa197
@madsrasmussen
export everything from global components
3f7c7ca
@madsrasmussen
rename folder to global components
7002cf7
@madsrasmussen
export everything from global components
5c286c0
@madsrasmussen
use alias in import
8c179ae
@madsrasmussen
Merge branch 'main' into v14/chore/bundle-templating-package
37c5dd8
@madsrasmussen
export picker context
667f45b
@madsrasmussen
export picker context
2cc8233
@madsrasmussen
export picker context
f5b4fa1
@madsrasmussen
export picker context
cfef70a
@madsrasmussen
export picker context
ca97497
@madsrasmussen
export picker context
3a9be7a
@madsrasmussen madsrasmussen marked this pull request as ready for review July 1, 2024 07:58
@madsrasmussen madsrasmussen changed the title Bundle: Templating package Bundling: Templating package Jul 1, 2024
@madsrasmussen madsrasmussen requested a review from iOvergaard July 2, 2024 06:02
iOvergaard
iOvergaard reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some exported classes being renamed here. Would that not be considered breaking changes, or were they not available to the public before?

@madsrasmussen
Copy link
Contributor Author

I renamed two classes:

  • UmbCreateEntityAction -> UmbCreateDocumentBlueprintEntityAction
  • UmbCreateEntityAction -> UmbCreateTemplateEntityAction

None of them are exported from the public module.

@iOvergaard iOvergaard merged commit 391065f into main Jul 3, 2024
@iOvergaard iOvergaard deleted the v14/chore/bundle-templating-package branch July 3, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
release/14.2.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @iOvergaard