Skip to content

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jun 28, 2024

Making the Block Grid Areas Property Editor UI propagate changes to the property value, so it can be persisted.

Fixes umbraco/Umbraco-CMS#16640

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review June 28, 2024 13:10
@nielslyngsoe nielslyngsoe requested a review from iOvergaard June 28, 2024 13:10
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried creating a layout with 4/8 areas and saved that, and that was persisted. Then tried adding blocks to those areas in a document, and those got persisted as well. LGTM.

@iOvergaard iOvergaard merged commit 144378a into release/14.1 Jun 28, 2024
@iOvergaard iOvergaard deleted the v14/hotfix/block-grid-area-type-propagate-data-changes branch June 28, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants