Skip to content

Conversation

iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Jun 24, 2024

Description

This maps the description property to the doc type model and displays it for block types.

Since the description field was added in umbraco/Umbraco-CMS#16503 it is now possible to fix this issue.

Fixes umbraco/Umbraco-CMS#16642

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

How to test?

  1. Add a description to an element type and add that type to a block property editor
  2. Add at least an addition block type (otherwise the block catalogue will not be shown)
  3. Verify that the description is shown underneath the name

Screenshots (if appropriate)

Before
image

After
image

This maps the `description` property to the doc type model and displays it for block types.
@iOvergaard iOvergaard enabled auto-merge June 24, 2024 12:44
@iOvergaard iOvergaard changed the title Bugfix: block types do not show their descriptions Bugfix: Block types do not show their descriptions Jun 24, 2024
Copy link
Contributor

@loivsen loivsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@iOvergaard iOvergaard merged commit b16a459 into main Jun 24, 2024
@iOvergaard iOvergaard deleted the v14/bugfix/block-type-descriptions branch June 24, 2024 13:17
@iOvergaard iOvergaard linked an issue Jun 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc type descriptions aren't pulling through to block list cards [BUG]: Descriptions are not shown in the block picker
2 participants