Skip to content

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jun 3, 2024

This PR ensures that the data of a Block Editor corresponds to the configuration, Well, only when revisited in the UI.

This also corrects document type picker + its property editor, so its value is undefined when empty. before it gave an empty string.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

  • Make a docType with a Block Editor
  • setup a Block Type with a settings model
  • Make a document of this type and create the data.
  • Remove the settings model from the Block Type.
  • Revisit the page to see that UI removes the data. you could save it, to inspect the Network calls, compare before with after.
  • There might be other similar cases that needs to be tested as well.

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review June 19, 2024 12:16
@nielslyngsoe nielslyngsoe merged commit b77c9dc into main Jun 24, 2024
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/correct-settings-data-depending-on-config branch June 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants