Skip to content

Chore: Split dictionary consts from manifests #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

Chore: Split dictionary consts from manifests #1937

merged 2 commits into from
May 28, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented May 28, 2024 •
edited
Loading

Description

Build on top of PR #1936

Split the constants from the manifest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen requested a review from leekelleher May 28, 2024 11:58
leekelleher
leekelleher approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, the Translation/dictionary section, and dictionary input picker still work as expected! 👍

@leekelleher leekelleher merged commit 29af6b7 into main May 28, 2024
@leekelleher leekelleher deleted the chore/split-dictionary-consts-from-manifests branch May 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @leekelleher