Skip to content

Amend accessibility modifiers on file upload property editor components to support extension#21653

Open
PeterKvayt wants to merge 3 commits intoumbraco:mainfrom
PeterKvayt:v17/improvement/21652-amend-modifiers-for-file-upload
Open

Amend accessibility modifiers on file upload property editor components to support extension#21653
PeterKvayt wants to merge 3 commits intoumbraco:mainfrom
PeterKvayt:v17/improvement/21652-amend-modifiers-for-file-upload

Conversation

@PeterKvayt
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #21652

Description

I have amended access modifiers to make FileUploadPropertyEditor extendable.
The main reason you can find in the issue above.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Hi there @PeterKvayt, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It is unable to extend FileUploadPropertyEditor

2 participants