Segments: Only validate segment values for cultures they are defined for (closes #21029)

[AndyButland]

Prerequisites

• I have added steps to test this contribution in the description below

Addresses: #21029

Description

This PR adds culture-aware segment validation to skip validating property values for segments not defined a culture.

See the linked issue for details of the concern and how to set up to test.

The issue comes as currently we don't look at what segments are defined when validating - we just take the aliases that come from the model. A defined segment though can have one or more cultures defined for it. If at least one culture is defined, the segment can be created only for those cultures. And as such, we shouldn't validate segments that aren't creatable for a culture.

In the first version of this PR I've resolved this by injecting ISegmentService to determine this.

After discussion I've removed this. We currently rely on the incoming model variants and properties to determine the segments, and we can do similar to find the segments along with the cultures they are associated with by looking at what culture and segment combinations are provided.

I've verified that this works for Save, Save and Publish and Publish operations on a document.

There's a small UI issue - that if tackled, should be handled in another PR - in that we still report publishing segments that aren't valid for a culture.

Which comes from this code in UmbPublishDocumentEntityAction.

// TODO: show correct variant names instead of variant strings [MR]
localize.list(documentVariants.map((v) => UmbVariantId.Create(v).toString() ?? v.name)),

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.