Skip to content

Delivery API: Missing Member Open API security scheme references#21020

Merged
lauraneto merged 1 commit intorelease/17.0from
v17/bugfix/missing-open-api-security-schema-references
Dec 1, 2025
Merged

Delivery API: Missing Member Open API security scheme references#21020
lauraneto merged 1 commit intorelease/17.0from
v17/bugfix/missing-open-api-security-schema-references

Conversation

@lauraneto
Copy link
Contributor

Fixes security requirements being serialized as empty objects in the OpenAPI document by using the document's AddComponent method instead of directly manipulating the SecuritySchemes dictionary.

Fixes security requirements being serialized as empty objects in the
OpenAPI document by using the document's AddComponent method instead
of directly manipulating the SecuritySchemes dictionary.
@lauraneto lauraneto requested review from Copilot and kjac December 1, 2025 15:47
@lauraneto lauraneto changed the title Delivery API: Missing Member Open API security schema references Delivery API: Missing Member Open API security scheme references Dec 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where security requirements were being serialized as empty objects in the OpenAPI document for the Delivery API's Member authentication. The fix changes from manually manipulating the SecuritySchemes dictionary to using the AddComponent method on OpenApiDocument, which properly registers the security scheme in the OpenAPI specification.

Key Changes:

  • Replaces manual initialization of Components and SecuritySchemes with a single AddComponent call
  • Simplifies the code by removing null-coalescing assignments
  • Addresses serialization issues in the OpenAPI document

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect 💯

@lauraneto lauraneto merged commit 1d59e20 into release/17.0 Dec 1, 2025
29 checks passed
@lauraneto lauraneto deleted the v17/bugfix/missing-open-api-security-schema-references branch December 1, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants