Installer: Removes unused telemetry functionality#20995
Merged
AndyButland merged 7 commits intomainfrom Nov 28, 2025
Merged
Conversation
…l InstallHelper functionality
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes non-functional telemetry functionality from the Umbraco installer that was previously sending data to Our.Umbraco.com. The changes obsolete the InstallHelper class and its SetInstallStatusAsync method while maintaining backward compatibility through obsolete constructor overloads, all scheduled for removal in Umbraco 19.
Key Changes
- Gutted
InstallHelperclass implementation, removing all telemetry-related logic while keeping the public API surface for backward compatibility - Removed calls to
SetInstallStatusAsyncfrom installer workflow (SettingsInstallController and RegisterInstallCompleteStep) - Added obsolete constructor overloads to maintain DI backward compatibility
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Umbraco.Infrastructure/Install/InstallHelper.cs | Marked entire class as obsolete, removed all field assignments and telemetry logic from constructor, converted SetInstallStatusAsync to a no-op method |
| src/Umbraco.Cms.Api.Management/Controllers/Install/SettingsInstallController.cs | Removed telemetry call from Settings endpoint, added obsolete constructor overload for backward compatibility with existing DI configurations |
| src/Umbraco.Infrastructure/Installer/Steps/RegisterInstallCompleteStep.cs | Removed InstallHelper field and telemetry call from Execute method, added obsolete constructor overload for backward compatibility |
src/Umbraco.Infrastructure/Installer/Steps/RegisterInstallCompleteStep.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Core/Persistence/Repositories/InstallationRepository.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Installer/Steps/RegisterInstallCompleteStep.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Install/SettingsInstallController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AndyButland
approved these changes
Nov 28, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
All looks good to me, thanks @iOvergaard. For good measure I tested the installer to make sure these updates had no negative effect on that functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InstallHelperclass and itsSetInstallStatusAsyncmethodBackground
Verified installer cookie usage all the way back to V8 - it was only ever used in this telemetry setting context. Removal approved in agreement with Sebastiaan.
Changes
SetInstallStatusAsyncto no-opSetInstallStatusAsynccall, added obsolete constructor overloadSetInstallStatusAsynccall, added obsolete constructor overloadTest plan
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com