Skip to content

Installer: Removes unused telemetry functionality#20995

Merged
AndyButland merged 7 commits intomainfrom
v17/bugfix/removes-unused-telemetry-installer
Nov 28, 2025
Merged

Installer: Removes unused telemetry functionality#20995
AndyButland merged 7 commits intomainfrom
v17/bugfix/removes-unused-telemetry-installer

Conversation

@iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Nov 28, 2025

Summary

  • Obsoletes the InstallHelper class and its SetInstallStatusAsync method
  • Removes telemetry calls from installer that were no longer functioning (sending data to Our.Umbraco.com)
  • Adds obsolete constructor overloads to maintain backward compatibility for DI
  • Scheduled for removal in Umbraco 19

Background

Verified installer cookie usage all the way back to V8 - it was only ever used in this telemetry setting context. Removal approved in agreement with Sebastiaan.

Changes

  • InstallHelper.cs: Gutted implementation, marked entire class as obsolete, converted SetInstallStatusAsync to no-op
  • SettingsInstallController.cs: Removed SetInstallStatusAsync call, added obsolete constructor overload
  • RegisterInstallCompleteStep.cs: Removed SetInstallStatusAsync call, added obsolete constructor overload

Test plan

  • Verify installer completes successfully without telemetry calls
  • Verify existing code using obsolete constructors still compiles with warnings
  • Verify new code can use parameterless constructors

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

Copilot AI review requested due to automatic review settings November 28, 2025 13:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes non-functional telemetry functionality from the Umbraco installer that was previously sending data to Our.Umbraco.com. The changes obsolete the InstallHelper class and its SetInstallStatusAsync method while maintaining backward compatibility through obsolete constructor overloads, all scheduled for removal in Umbraco 19.

Key Changes

  • Gutted InstallHelper class implementation, removing all telemetry-related logic while keeping the public API surface for backward compatibility
  • Removed calls to SetInstallStatusAsync from installer workflow (SettingsInstallController and RegisterInstallCompleteStep)
  • Added obsolete constructor overloads to maintain DI backward compatibility

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/Umbraco.Infrastructure/Install/InstallHelper.cs Marked entire class as obsolete, removed all field assignments and telemetry logic from constructor, converted SetInstallStatusAsync to a no-op method
src/Umbraco.Cms.Api.Management/Controllers/Install/SettingsInstallController.cs Removed telemetry call from Settings endpoint, added obsolete constructor overload for backward compatibility with existing DI configurations
src/Umbraco.Infrastructure/Installer/Steps/RegisterInstallCompleteStep.cs Removed InstallHelper field and telemetry call from Execute method, added obsolete constructor overload for backward compatibility

@iOvergaard iOvergaard changed the title Installer: Removes unused telemetry functionality (closes #20981) Installer: Removes unused telemetry functionality Nov 28, 2025
@iOvergaard iOvergaard requested a review from Copilot November 28, 2025 14:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, thanks @iOvergaard. For good measure I tested the installer to make sure these updates had no negative effect on that functionality.

@AndyButland AndyButland merged commit 050b37e into main Nov 28, 2025
26 checks passed
@AndyButland AndyButland deleted the v17/bugfix/removes-unused-telemetry-installer branch November 28, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants