E2E: QA added entity picker acceptance tests#20776
Merged
Conversation
…ker-acceptance-tests # Conflicts: # tests/Umbraco.Tests.AcceptanceTest/package-lock.json # tests/Umbraco.Tests.AcceptanceTest/package.json
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive acceptance tests for the Entity Data Picker feature in Umbraco CMS, covering both tree and collection data source implementations. The tests validate data type creation, content creation with validation rules, and content rendering scenarios.
Key Changes
- Added acceptance tests for Entity Data Picker with tree and collection data sources
- Implemented custom data source plugins for test fixtures
- Updated test helper dependencies to support new test functionality
- Configured CI/CD pipelines to run Entity Data Picker tests on Windows and Linux
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerTree.spec.ts | Tests content creation with tree data source, including validation for min/max items |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts | Tests content creation with collection data source, including validation scenarios |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/DataType/EntityPickerTree.spec.ts | Tests data type creation UI for tree data source |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/DataType/EntityPickerCollection.spec.ts | Tests data type creation UI for collection data source |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerTree.spec.ts | Tests rendering of content with tree data source values |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerCollection.spec.ts | Tests rendering of content with collection data source values |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/AdditionalSetup/appsettings.json | Test configuration for Entity Data Picker tests |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/umbraco-package.json | Package definition for custom picker data sources |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/tree-api.js | Tree data source implementation for testing |
| tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/collection-api.js | Collection data source implementation for testing |
| tests/Umbraco.Tests.AcceptanceTest/playwright.config.ts | Added entityDataPicker test project configuration |
| tests/Umbraco.Tests.AcceptanceTest/package.json | Updated test helper dependencies |
| tests/Umbraco.Tests.AcceptanceTest/package-lock.json | Updated dependency lock file |
| build/nightly-E2E-test-pipelines.yml | Added Windows and Linux test jobs for Entity Data Picker |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerTree.spec.ts
Show resolved
Hide resolved
...t/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/umbraco-package.json
Outdated
Show resolved
Hide resolved
...t/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/umbraco-package.json
Outdated
Show resolved
Hide resolved
...t/tests/EntityDataPicker/AdditionalSetup/App_Plugins/picker-data-source/umbraco-package.json
Outdated
Show resolved
Hide resolved
...o.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerTree.spec.ts
Outdated
Show resolved
Hide resolved
nhudinh0309
requested changes
Nov 11, 2025
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...o.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerTree.spec.ts
Outdated
Show resolved
Hide resolved
...o.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
nhudinh0309
approved these changes
Nov 11, 2025
Contributor
nhudinh0309
left a comment
nhudinh0309
left a comment
There was a problem hiding this comment.
Had more comments. You can merge after fix them.
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...s/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/Content/EntityPickerTree.spec.ts
Outdated
Show resolved
Hide resolved
.../Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/DataType/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/DataType/EntityPickerTree.spec.ts
Outdated
Show resolved
Hide resolved
...o.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerCollection.spec.ts
Outdated
Show resolved
Hide resolved
...Umbraco.Tests.AcceptanceTest/tests/EntityDataPicker/RenderedContent/EntityPickerTree.spec.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.