Skip to content

Slider property editor: Fix for preset value handling of enableRange #20772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 1 commit into from
Nov 9, 2025
Merged

Slider property editor: Fix for preset value handling of enableRange #20772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...mbraco.Web.UI.Client/src/packages/property-editors/slider/slider-property-value-preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
implements UmbPropertyValuePreset<UmbSliderPropertyEditorUiValue, UmbPropertyEditorConfig>
{
async processValue(value: undefined | UmbSliderPropertyEditorUiValue, config: UmbPropertyEditorConfig) {
const enableRange = Boolean(config.find((x) => x.alias === 'enableRange') ?? false);
const enableRange = Boolean(config.find((x) => x.alias === 'enableRange')?.value ?? false);

/*
const min = Number(config.find((x) => x.alias === 'minVal') ?? 0);
const max = Number(config.find((x) => x.alias === 'maxVal') ?? 100);
const min = Number(config.find((x) => x.alias === 'minVal')?.value ?? 0);
const max = Number(config.find((x) => x.alias === 'maxVal')?.value ?? 100);
const minVerified = isNaN(min) ? undefined : min;
const maxVerified = isNaN(max) ? undefined : max;
*/

const step = (config.find((x) => x.alias === 'step') as number | undefined) ?? 0;
const step = Number(config.find((x) => x.alias === 'step')?.value ?? 0);

Check warning on line 18 in src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/slider-property-value-preset.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

❌ Getting worse: Complex Method 

UmbSliderPropertyValuePreset.processValue increases in cyclomatic complexity from 10 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
const stepVerified = step > 0 ? step : 1;

const initValueMin = Number(config.find((x) => x.alias === 'initVal1')?.value) || 0;
Expand Down
Loading