Localization: Supply the display name to the localization key for the alt and title attributes of the 2FA QR code image#20770
Merged
AndyButland merged 1 commit intoumbraco:mainfrom Nov 9, 2025
Conversation
… 2FA QR Code Image
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the accessibility and user experience of the MFA (Multi-Factor Authentication) QR code by adding the provider's display name as a parameter to the localization terms for the alt and title attributes of the QR code image.
- Updated
altandtitleattributes to include the provider display name for better context - Changed from generic localization keys to parameterized versions
AndyButland
approved these changes
Nov 9, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Nice, thanks @warrenbuckley for spotting and fixing this.
AndyButland
changed the title
alt and title attributes of the 2FA QR code image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
A very simple fix to supply the display name to the localization key for the 2FA QR Code Image
Prerequisites
Description
The quickest way to test is to install 2FA package into the Umbraco site. Saves you setting up a MFA provider and the extension manifest yourself
dotnet add package Umbraco.Community.User2FA --version 1.0.2Before
After