Skip to content

E2E: QA cherry picked acceptance tests updates from 17 #20714

Merged
andr317c merged 3 commits intov16/devfrom
v16/QA/updated-acceptance-tests-with-changes-from-17
Nov 4, 2025
Merged

E2E: QA cherry picked acceptance tests updates from 17 #20714
andr317c merged 3 commits intov16/devfrom
v16/QA/updated-acceptance-tests-with-changes-from-17

Conversation

@andr317c
Copy link
Contributor

@andr317c andr317c commented Nov 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 3, 2025 11:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates acceptance tests to align with changes in the @umbraco/playwright-testhelpers package (version 16.0.58), including method renames, updated error messages, and test improvements.

  • Updated test helper method calls to use renamed functions
  • Corrected error message expectations to match updated backend validation text
  • Improved test reliability by adding navigation steps and skipping flaky tests

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Webhook/Webhook.spec.ts Removed @release tags from three webhook tests
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts Added navigation to media section before verifying media thumbnail
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts Updated error message expectation to match corrected backend validation text
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts Updated error message expectation to match corrected backend validation text
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CreateContentFromDocumentBlueprint.spec.ts Renamed method calls from clickModalMenuItemWithName to selectDocumentBlueprintWithName
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts Updated assertion to check actual false value instead of empty array
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts Replaced tree navigation with list view navigation for duplicate content verification
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts Marked cross-document clipboard test as skipped with issue reference
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts Marked cross-document clipboard test as skipped with issue reference
tests/Umbraco.Tests.AcceptanceTest/package.json Updated @umbraco/playwright-testhelpers dependency to version 16.0.58
tests/Umbraco.Tests.AcceptanceTest/package-lock.json Updated lock file for @umbraco/playwright-testhelpers version 16.0.58
build/nightly-E2E-test-pipelines.yml Added v16/dev branch to nightly E2E test schedule
Files not reviewed (1)
  • tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts:114

  • Avoid automated semicolon insertion (94% of all statements in the enclosing function have an explicit semicolon).
  const documentType = await umbracoApi.documentType.getByName(documentTypeName)

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts:114

  • Avoid automated semicolon insertion (94% of all statements in the enclosing function have an explicit semicolon).
  const documentType = await umbracoApi.documentType.getByName(documentTypeName)

Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andr317c andr317c merged commit 76fed82 into v16/dev Nov 4, 2025
32 checks passed
@andr317c andr317c deleted the v16/QA/updated-acceptance-tests-with-changes-from-17 branch November 4, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants