E2E: QA cherry picked acceptance tests updates from 17 #20714
Merged
E2E: QA cherry picked acceptance tests updates from 17 #20714
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates acceptance tests to align with changes in the @umbraco/playwright-testhelpers package (version 16.0.58), including method renames, updated error messages, and test improvements.
- Updated test helper method calls to use renamed functions
- Corrected error message expectations to match updated backend validation text
- Improved test reliability by adding navigation steps and skipping flaky tests
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Webhook/Webhook.spec.ts | Removed @release tags from three webhook tests |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts | Added navigation to media section before verifying media thumbnail |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts | Updated error message expectation to match corrected backend validation text |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts | Updated error message expectation to match corrected backend validation text |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CreateContentFromDocumentBlueprint.spec.ts | Renamed method calls from clickModalMenuItemWithName to selectDocumentBlueprintWithName |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts | Updated assertion to check actual false value instead of empty array |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts | Replaced tree navigation with list view navigation for duplicate content verification |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts | Marked cross-document clipboard test as skipped with issue reference |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts | Marked cross-document clipboard test as skipped with issue reference |
| tests/Umbraco.Tests.AcceptanceTest/package.json | Updated @umbraco/playwright-testhelpers dependency to version 16.0.58 |
| tests/Umbraco.Tests.AcceptanceTest/package-lock.json | Updated lock file for @umbraco/playwright-testhelpers version 16.0.58 |
| build/nightly-E2E-test-pipelines.yml | Added v16/dev branch to nightly E2E test schedule |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts:114
- Avoid automated semicolon insertion (94% of all statements in the enclosing function have an explicit semicolon).
const documentType = await umbracoApi.documentType.getByName(documentTypeName)
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts:114
- Avoid automated semicolon insertion (94% of all statements in the enclosing function have an explicit semicolon).
const documentType = await umbracoApi.documentType.getByName(documentTypeName)
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.