WorkspaceView: Add tests for create and using custom workspace view#20408
Merged
NguyenThuyLan merged 11 commits intomainfrom Oct 15, 2025
Merged
WorkspaceView: Add tests for create and using custom workspace view#20408NguyenThuyLan merged 11 commits intomainfrom
NguyenThuyLan merged 11 commits intomainfrom
Conversation
…6/QA/custom-workspace-view
…6/QA/custom-workspace-view
nhudinh0309
requested changes
Oct 14, 2025
Contributor
nhudinh0309
left a comment
nhudinh0309
left a comment
There was a problem hiding this comment.
Had a couple of comments. And you should format code with the indention tab is 2 spaces instead of 4 spaces.
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/WorkspaceView.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/WorkspaceView.spec.ts
Outdated
Show resolved
Hide resolved
…kspaceView.spec.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com>
…kspaceView.spec.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com>
nhudinh0309
requested changes
Oct 15, 2025
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/WorkspaceView.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/WorkspaceView.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/WorkspaceView.spec.ts
Outdated
Show resolved
Hide resolved
…kspaceView.spec.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com>
…kspaceView.spec.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com>
…kspaceView.spec.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test ensures that workspace view appears in the right places.
The custom workspace view in this test has conditions match to Content Section, so there are two test:
custom workspace view is visible in content section
custom workspace view is not visible in media section