-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Login: Added custom validation for missing password and user/email on the login form #20233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leekelleher
merged 24 commits into
main
from
v16/bugfix/login-missing-mandatory-fields-fix
Nov 10, 2025
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a015518
Added custom validation for missing password and user/email
MrHutmat dc35c52
Changed some of the logic behind custom validation, so it now uses ar…
MrHutmat 0a2d064
Merge remote-tracking branch 'origin/main' into v16/bugfix/login-miss…
iOvergaard 5eb54d6
fix: imports from src folder instead
iOvergaard 2e84206
build(deps-dev): bump vite to 7.2.0
iOvergaard 6e07528
formatting
iOvergaard 302975b
fix: moves the form into the login.page.element.ts component to bette…
iOvergaard b87d23b
fix: creates elements globally
iOvergaard 25459d7
fix: adds id back to form
iOvergaard e2ff9e7
fix: no need to store references to all form elements
iOvergaard 9acaf64
fix: errormessage should show with password field in a span as well
iOvergaard 36ba61d
fix: checks validity of form
iOvergaard 053a4ab
fix: constructs form in auth.element.ts anyway and append localizatio…
iOvergaard 2f9ed74
chore: fixes import paths
iOvergaard c64b567
fix: fixes special case where ?status was not reset
iOvergaard d766374
fix: changes wording in english
iOvergaard 4f20cbe
fix: removes duplicate en-us keys
iOvergaard 787d793
feat: adds ariaLive and role attributes
iOvergaard 7736421
Merge branch 'main' into v16/bugfix/login-missing-mandatory-fields-fix
iOvergaard 8570587
fix: always clears the text
iOvergaard 0a1eaa2
fix: username required validation should switch between username and …
iOvergaard 3f7e557
Merge branch 'main' into v16/bugfix/login-missing-mandatory-fields-fix
leekelleher 04f29c4
package-lock.json updated on (re)install
leekelleher 77a3344
Renamed SVG eye icon filenames
leekelleher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,54 @@ | ||
| #umb-login-form .validation-message { | ||
| color: var(--uui-color-invalid-standalone); | ||
| display: none; | ||
| margin-top: var(--uui-size-1); | ||
| } | ||
|
|
||
| #umb-login-form .validation-message[state='error'] { | ||
| display: block; | ||
| } | ||
|
|
||
| #umb-login-form input { | ||
| width: 100%; | ||
| height: var(--input-height); | ||
| box-sizing: border-box; | ||
| display: block; | ||
| border: 1px solid var(--uui-color-border); | ||
| border-radius: var(--uui-border-radius); | ||
| background-color: var(--uui-color-surface); | ||
| padding: var(--uui-size-1, 3px) var(--uui-size-space-4, 9px); | ||
| width: 100%; | ||
| height: var(--input-height); | ||
| box-sizing: border-box; | ||
| display: block; | ||
| border: 1px solid var(--uui-color-border); | ||
| border-radius: var(--uui-border-radius); | ||
| background-color: var(--uui-color-surface); | ||
| padding: var(--uui-size-1, 3px) var(--uui-size-space-4, 9px); | ||
| } | ||
|
|
||
| #umb-login-form uui-form-layout-item { | ||
| margin-top: var(--uui-size-space-4); | ||
| margin-bottom: var(--uui-size-space-4); | ||
| margin-top: var(--uui-size-space-4); | ||
| margin-bottom: var(--uui-size-space-4); | ||
| } | ||
|
|
||
| #umb-login-form input:focus-within { | ||
| border-color: var(--uui-input-border-color-focus, var(--uui-color-border-emphasis, #a1a1a1)); | ||
| outline: calc(2px * var(--uui-show-focus-outline, 1)) solid var(--uui-color-focus); | ||
| border-color: var(--uui-input-border-color-focus, var(--uui-color-border-emphasis, #a1a1a1)); | ||
| outline: calc(2px * var(--uui-show-focus-outline, 1)) solid var(--uui-color-focus); | ||
| } | ||
|
|
||
| #umb-login-form input:hover:not(:focus-within) { | ||
| border-color: var(--uui-input-border-color-hover, var(--uui-color-border-standalone, #c2c2c2)); | ||
| border-color: var(--uui-input-border-color-hover, var(--uui-color-border-standalone, #c2c2c2)); | ||
| } | ||
|
|
||
| #umb-login-form input::-ms-reveal { | ||
| display: none; | ||
| display: none; | ||
| } | ||
|
|
||
| #umb-login-form input span { | ||
| position: absolute; | ||
| right: 1px; | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| z-index: 100; | ||
| position: absolute; | ||
| right: 1px; | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| z-index: 100; | ||
| } | ||
|
|
||
| #umb-login-form input span svg { | ||
| background-color: white; | ||
| display: block; | ||
| padding: .2em; | ||
| width: 1.3em; | ||
| height: 1.3em; | ||
| background-color: white; | ||
| display: block; | ||
| padding: 0.2em; | ||
| width: 1.3em; | ||
| height: 1.3em; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.