Property Type workspace: layout & labeling adjustments#20131
Merged
nielslyngsoe merged 27 commits intov17/devfrom Oct 8, 2025
Merged
Property Type workspace: layout & labeling adjustments#20131nielslyngsoe merged 27 commits intov17/devfrom
nielslyngsoe merged 27 commits intov17/devfrom
Conversation
...raco.Web.UI.Client/src/packages/core/components/input-with-alias/input-with-alias.element.ts
Outdated
Show resolved
Hide resolved
...b.UI.Client/src/packages/core/property/components/property-layout/property-layout.element.ts
Outdated
Show resolved
Hide resolved
madsrasmussen
requested changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
It looks really good. I have left a few inline comments for things I think we should update in the code.
I also noticed that we have a variation part inside the validation box. What do you think about moving "shared across cultures" and "shared across segments" to its own box?
It also looks like there is a tiny bit of extra spacing in the top and bottom of the boxes. Now when we take up more space, it would be nice to have it as tight as possible. Maybe it would be possible to remove top-padding from the first property-layout and bottom-padding from the last property-layout element in a box?
Contributor
Author
# Conflicts: # src/Umbraco.Core/Services/DocumentUrlService.cs
nielslyngsoe
approved these changes
Oct 2, 2025
madsrasmussen
approved these changes
Oct 7, 2025
…orkIdle has changed
madsrasmussen
added a commit
that referenced
this pull request
Oct 10, 2025
* Property workspace update * Fixed error with updating the properties * Unused variable * Added data-mark to description textarea * make select 100% width * tiny appearance-option style adjustments * Make placeholder property inside the input-with-alias optional * Moving variations and member type option to their own boxes --------- Co-authored-by: Mads Rasmussen <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
Name + Alias
Switched to umb-input-with-alias (combined control).
Description
Added localized label and border (consistent with inputs).
Layout
Wrapped sections in uui-box + umb-property-layout for consistent spacing/structure.
Cleaned unused CSS; aligned styles with existing components.
Replaced hard-coded strings with this.localize.term(...) across the modal.
Other components/elements updates:
umb-input-with-alias: split placeholder from label props.
umb-property-layout (minor style polish).