Skip to content

Property Type workspace: layout & labeling adjustments#20131

Merged
nielslyngsoe merged 27 commits intov17/devfrom
v16/fix/PropertyType-layout-style
Oct 8, 2025
Merged

Property Type workspace: layout & labeling adjustments#20131
nielslyngsoe merged 27 commits intov17/devfrom
v16/fix/PropertyType-layout-style

Conversation

@engijlr
Copy link
Contributor

@engijlr engijlr commented Sep 13, 2025

What changed

Name + Alias
Switched to umb-input-with-alias (combined control).

Description
Added localized label and border (consistent with inputs).

Layout
Wrapped sections in uui-box + umb-property-layout for consistent spacing/structure.
Cleaned unused CSS; aligned styles with existing components.
Replaced hard-coded strings with this.localize.term(...) across the modal.

Other components/elements updates:
umb-input-with-alias: split placeholder from label props.
umb-property-layout (minor style polish).

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good. I have left a few inline comments for things I think we should update in the code.

I also noticed that we have a variation part inside the validation box. What do you think about moving "shared across cultures" and "shared across segments" to its own box?

Screenshot 2025-09-19 at 09 56 22

It also looks like there is a tiny bit of extra spacing in the top and bottom of the boxes. Now when we take up more space, it would be nice to have it as tight as possible. Maybe it would be possible to remove top-padding from the first property-layout and bottom-padding from the last property-layout element in a box?

@engijlr
Copy link
Contributor Author

engijlr commented Sep 21, 2025

Updates based on review:

-Moved “Shared across cultures” and “Shared across segments” out of Validation into their own uui-box.
-Moved Member type options into their own box(see picture):
Screenshot 2025-09-21 at 15 21 03

-Removed top padding on the first and bottom padding on the last umb-property-layout in each uui-box (change just locally to this view; no global impact).
-Reverted global padding change on umb-property-layout (no global impact).
-Removed placeholder fallback and made it optional inside umb-input-with-alias.

@nielslyngsoe nielslyngsoe changed the base branch from main to v17/dev October 2, 2025 13:02
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) October 2, 2025 13:20
@madsrasmussen madsrasmussen added the category/ux User experience label Oct 7, 2025
@madsrasmussen madsrasmussen changed the title PropertyType workspace: layout & labeling adjustments Property Type workspace: layout & labeling adjustments Oct 7, 2025
@madsrasmussen madsrasmussen self-assigned this Oct 7, 2025
@nielslyngsoe nielslyngsoe merged commit d6ce8d9 into v17/dev Oct 8, 2025
27 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/fix/PropertyType-layout-style branch October 8, 2025 18:24
madsrasmussen added a commit that referenced this pull request Oct 10, 2025
* Property workspace update

* Fixed error with updating the properties

* Unused variable

* Added data-mark to description textarea

* make select 100% width

* tiny appearance-option style adjustments

* Make placeholder property inside the input-with-alias optional

* Moving variations and member type option to their own boxes

---------

Co-authored-by: Mads Rasmussen <[email protected]>
Co-authored-by: Niels Lyngsø <[email protected]>
Co-authored-by: Niels Lyngsø <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants