Fix spell error from "Segmment" to "Segment" in the IRequestSegment interface#20010
Conversation
|
Hi there @rammi987, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks for this contribution @rammi987. Unfortunately we need to tackle this in a slightly different way, so we adhere to our rules about obsoletion periods and avoiding binary breaking changes in minor releases. Would you be up for looking to re-work as I've suggested please?
AndyButland
left a comment
There was a problem hiding this comment.
All looks good to me now. I've also tested locally and verified that segmented content continues to be provided. Thanks for the contribution @rammi987.
Fund a spelling error, while using the IRequestSegment services. I saw that the service was correct spelled, along with the interface fil, but not the Interface itself.