Skip to content

Fix spell error from "Segmment" to "Segment" in the IRequestSegment interface#20010

Merged
AndyButland merged 3 commits intoumbraco:mainfrom
rammi987:spellfix/Segment-spell-segmment
Sep 9, 2025
Merged

Fix spell error from "Segmment" to "Segment" in the IRequestSegment interface#20010
AndyButland merged 3 commits intoumbraco:mainfrom
rammi987:spellfix/Segment-spell-segmment

Conversation

@rammi987
Copy link
Contributor

Fund a spelling error, while using the IRequestSegment services. I saw that the service was correct spelled, along with the interface fil, but not the Interface itself.

@github-actions
Copy link

Hi there @rammi987, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @rammi987. Unfortunately we need to tackle this in a slightly different way, so we adhere to our rules about obsoletion periods and avoiding binary breaking changes in minor releases. Would you be up for looking to re-work as I've suggested please?

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me now. I've also tested locally and verified that segmented content continues to be provided. Thanks for the contribution @rammi987.

@AndyButland AndyButland merged commit 3cc5715 into umbraco:main Sep 9, 2025
25 checks passed
@AndyButland AndyButland changed the title Fix spell error from Segmment to Segment Fix spell error from "Segmment" to "Segment" in the IRequestSegment interface Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants