Fix removal of check on removal the final admin user #19921
+138
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #19917
Description
This PR resolves the issue highlighted and diagnosed to be due to the user group repository cache holding onto counts of the number of users in the group. This gets out of date as groups are added and removed from users. See: #19917 (comment)
To resolve I've added steps that invalidates the cache for each affected user group when added to or removed from a user, or if the user is deleted.
In passing I've also implemented a
TODO
around optimising the update of user groups for a user, so we don't just remove and add but make only the updates necessary.Integration tests have been added to verify both the refactoring and the fixed behaviour.
Testing
See the linked issue.
Also verify that groups can be added to and removed from user as expected.