WIP: Time zone support for date time picker #19915
Draft
+2,369
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Display UTC offset instead of short offset name in label.
lauraneto
commented
Aug 14, 2025
src/Umbraco.Core/PropertyEditors/DateTimeWithTimeZonePropertyEditor.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+83
to
+86
| label=${this.localize.string(item.label) + | ||
| (item.invalid ? ` (${this.localize.term('validation_legacyOption')})` : '')} | ||
| title=${item.invalid ? this.localize.term('validation_legacyOptionDescription') : ''}> | ||
| </uui-radio> |
There was a problem hiding this comment.
Should do a separate PR just with this change.
This adds support for localization of radio button labels.
…ic for the property editor
…nger available, instead of pre-selecting another one
This most likely means that the configuration of the editor changed to add time zone support. In this case we want to force the editor to select the applicable time zone.
lauraneto
commented
Aug 21, 2025
| object? dataTypeConfiguration, | ||
| PropertyValidationContext validationContext) | ||
| { | ||
| if (value is not JsonObject valueAsJsonObject) |
There was a problem hiding this comment.
I was just testing this and noticed that when the value is being saved, the value received is a JsonObject, but when it is being published it is a string (it seems to be what is stored in the database).
In both occasions the valueType is STRING.
I'm wondering whether I should also add validation to the provided string? Or should I actually only be validating the string, and not when the value is saved? 🤔
lauraneto
commented
Aug 22, 2025
Comment on lines
37
to
45
| export interface UmbDateTimeWithTimeZone { | ||
| date: string | undefined; | ||
| timeZone: string | undefined; | ||
| } | ||
|
|
||
| export interface UmbTimeZonePickerValue { | ||
| mode: 'all' | 'local' | 'custom'; | ||
| timeZones: Array<string>; | ||
| } |
There was a problem hiding this comment.
These should probably move next to the property editor, as they are not shared?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring options for a time zone aware date time property editor.
Work in progress.