V15: Serverside Media Picker Validation#18429
Merged
nikolajlauridsen merged 15 commits intov15/devfrom Feb 25, 2025
Merged
Conversation
AndyButland
reviewed
Feb 25, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
Looks an elegant solution to me. Will do a little manual testing but first leave my comments from reading over the code. Mostly nit-picks but see what you think about more efficiently handing multiple media selections and my comment on the test parameters.
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Show resolved
Hide resolved
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Show resolved
Hide resolved
src/Umbraco.Core/PropertyEditors/Validation/ITypedJsonValidator.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
Outdated
Show resolved
Hide resolved
...braco.Tests.UnitTests/Umbraco.Core/PropertyEditors/MediaPicker3ValueEditorValidationTests.cs
Show resolved
Hide resolved
...braco.Tests.UnitTests/Umbraco.Core/PropertyEditors/MediaPicker3ValueEditorValidationTests.cs
Outdated
Show resolved
Hide resolved
AndyButland
reviewed
Feb 25, 2025
...braco.Tests.UnitTests/Umbraco.Core/PropertyEditors/MediaPicker3ValueEditorValidationTests.cs
Outdated
Show resolved
Hide resolved
AndyButland
approved these changes
Feb 25, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
Test out fine locally as indicated. Approving with comments, so fine to merge once you have considered the points raised.
Co-authored-by: Andy Butland <abutland73@gmail.com>
Contributor
Author
|
Thanks for the review Andy, some good points 👍 I've applied all the points, and added some additional test 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds serverside validation for media picker, also adds a pattern to better support validation for JSON type property editors.
Testing
I've added unit tests, but to test manually:
This way you don't have to mess around with sending raw requests 😄