Fix: stop using redirects in collections#18112
Merged
madsrasmussen merged 1 commit intov15/devfrom Jan 24, 2025
Merged
Conversation
madsrasmussen
approved these changes
Jan 24, 2025
Contributor
madsrasmussen
left a comment
There was a problem hiding this comment.
Great! This also resolves another issue where navigating to a folder (Ex. Document Types Root) would not highlight the sidebar menu item as active due to the redirects. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a certain fix, but we generally seen redirects as bad.
Its because we sometimes have a case where the browser loads the Media section before Content, and a redirect of the Media Section changes the URl so they user now stays on Media, despite the user did not want to navigate to the media section.
It only happens occasionally so this is more of a try, by doing the thing we have done elsewhere to fix this issue — which is stop using redirects. :-D