Skip to content

Tiptap RTE: Add CSS support for extensions#18075

Merged
leekelleher merged 3 commits intov15/devfrom
v15/feature/tiptap-extension-styles
Jan 31, 2025
Merged

Tiptap RTE: Add CSS support for extensions#18075
leekelleher merged 3 commits intov15/devfrom
v15/feature/tiptap-extension-styles

Conversation

@leekelleher
Copy link
Member

Description

This feature is intended for Umbraco 15.3.

Introduces a getStyles() method for Tiptap extensions. This enables an individual Tiptap extension to define their own CSS rules.

For the initial implementation, the CSS rules for extensions were all placed within the umb-input-tiptap component regardless whether they are enabled or not.

This PR moves the CSS rules for the built-in Embedded Media, Image and Table to its own extension.

How to test

With the Tiptap RTE, enable any of the following extensions (Embedded Media, Image and/or Table), load up the RTE on a document, are the styles for those extensions present?

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
@leekelleher leekelleher enabled auto-merge (squash) January 30, 2025 10:39
@leekelleher leekelleher merged commit 9323d8b into v15/dev Jan 31, 2025
29 checks passed
@leekelleher leekelleher deleted the v15/feature/tiptap-extension-styles branch January 31, 2025 12:24
@iOvergaard iOvergaard added the category/dx Developer experience label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants