Skip to content

V15: Fix Url Preview#18072

Merged
Zeegaan merged 4 commits intov15/devfrom
v15/fix/fix-url-overview
Jan 29, 2025
Merged

V15: Fix Url Preview#18072
Zeegaan merged 4 commits intov15/devfrom
v15/fix/fix-url-overview

Conversation

@nikolajlauridsen
Copy link
Contributor

Fixes #17952

There was both a functional and an architectural issue here.

Fucntionally the IUrlProvider.GetOtherUrls wasn't listed in the V15 backoffice, in fact, custom IUrlProviders wasn't taken into account at all.

This was because a new method IDocumentUrlService.ListUrlsAsync was used. This does not work, because IDocumentUrlService is what's used by the default IUrlProvider internally, meaning that the IUrlProviders can never be taken into account here, due to circular references, additionally this would only take into account "default" urls.

To fix this I've moved the responsibility of listing urls into its own service IPublishedUrlInfoProvider which uses the IUrlProviders to generate the urls. This is very simiklar to the old behaviour in GetContentUrlsAsync. This means that the listed URLS are now aligned with how they used to be in V13.

Testing

See issue for testing steps.

Additionally:

  1. Add an additional language
  2. Create a piece of content that does not vary by culture
  3. Configure domains (see screenshot)
  4. Create a child
  5. Ensure that they're listed in the URL overview

image

Listed urls:
image

Do note that /da/ is there twice, this is the same as in V13, once from "normal" urls and once from "other urls"

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 🚀

@Zeegaan Zeegaan merged commit 1752be9 into v15/dev Jan 29, 2025
27 of 28 checks passed
@Zeegaan Zeegaan deleted the v15/fix/fix-url-overview branch January 29, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants