Skip to content

Fix settings value begin indifference

9d73d0d
Select commit
Loading
Failed to load commit list.
Merged

Fix settings value begin indifference (17989) #18022

Fix settings value begin indifference
9d73d0d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Jan 17, 2025 in 33s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.54 (8.41 -> 8.95)

  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Conditional block-entry.context.ts: UmbBlockEntryContext.contentValues 🔥
  • Complex Conditional block-entry.context.ts: UmbBlockEntryContext.settingsValues 🔥

Annotations

Check notice on line 247 in src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Complex Conditional

UmbBlockEntryContext.contentValues no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check notice on line 273 in src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Complex Conditional

UmbBlockEntryContext.settingsValues no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.