Merged
Conversation
iOvergaard
requested changes
Jan 16, 2025
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
I think it looks great and only have a few comments. I also think the UX is great especially considering we already had the content trees in a modal. It makes sense that the buttons are at the top and the whole form acts as a funnel to ensure the user can only ever get a valid result before submitting.
...o.Web.UI.Client/src/packages/multi-url-picker/link-picker-modal/link-picker-modal.element.ts
Outdated
Show resolved
Hide resolved
...o.Web.UI.Client/src/packages/multi-url-picker/link-picker-modal/link-picker-modal.element.ts
Outdated
Show resolved
Hide resolved
...o.Web.UI.Client/src/packages/multi-url-picker/link-picker-modal/link-picker-modal.element.ts
Show resolved
Hide resolved
This was referenced Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reworks the Link Picker modal UX flow.
Following a review of issue #17411, the idea was to introduce validation in the Link Picker modal, so that a user could configure the link to either enter a URL or an anchor/querystring value. During the review, we found that the UX flow could be reworked to help guide the user.
Recording.2025-01-15.173233.mp4
The initial field is "Source", this enables the link type selection, from either Document, Media or to manually enter a URL (external link). The configured source can be removed, whilst maintaining the other field values, so that a previously selected Document URL could be switched to be a manual URL and modified accordingly.
Fixes #17411
Fixes #17974