Merged
Conversation
iOvergaard
approved these changes
Dec 5, 2024
iOvergaard
requested changes
Dec 5, 2024
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
The build is failing, I think due to the change from ! to ? on the tiptap element.
iOvergaard
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the tiptap configuration styling for a more minimalistic look and a better overview of the parts that matters.
This has one noticeable UX change, the delete button for a group of toolbar actions is hidden, and only visible once a group is empty — This gives a better overview, but makes it harder as a user to empty out a group.
In my opinion that is acceptable, in this way its more of an active choice
— if users miss this, we should look into adding a context-bar on top of a group, which appear on hover/focus and has a delete button. This bar will also enable user to move the group and in this way enable a better experience when organizing the toolbar.
— Also if users find it annoying to clean up, we should either just remove actions that are not supported by a feature. Or hide them in the actual Property Editor, so they do not show up here.