V13: Add rcl files to static files tree#17671
Merged
Conversation
Zeegaan
added a commit
that referenced
this pull request
Jan 9, 2025
* Refactor to use IWebhostEnvironment for wwwroot files. * Obsolete ctor * Add ActivatorUtiiliesConstructor * Refactor logic to include folders * Fix so we can see files in wwwroot/App_Plugins * Cosmetic: Use invariant comparison for the "umbraco" folder". --------- Co-authored-by: kjac <kja@umbraco.dk>
Member
Author
|
Cherry picked for 13.6 🚀 |
This was referenced Jan 23, 2025
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15956
Notes
StaticFilesTreeControllerto now useIWebhostEnvironmentto get wwwroot files, this will then also get files from RCLs.pathis empty, we assume we are "just" asking for the root folders "wwwroot" & appplugins,This was the business logic before, and was filtered by this code
if (id == Constants.System.RootString && directory != AppPlugins && directory != Webroot)IPhysicalFileSystem, so the behavior will remain, as you cannot put RCL files in there. (It has to be in wwwroot)IWebHostEnvironment.WebRootFileProvider, but the path is a little weird here, so we have to recalculate, as when you pass in "" in the.GetDirectories, this will assume you are already in/wwwrootStaticFilesServiceHow to test
wwwrootfolder, here is my csproj from my test project: