Use TryParse when parsing ID from claims

[Oxygen-cl]

Issue: 17383

Prerequisites

• Add an external login provider (I tested with EntraID)

If there's an existing issue for this PR then this fixes #17383

Description

After some investigation, I found that the issue lies in the GetId method in Umbraco.Extensions.ClaimsIdentityExtensions.

The identity, after the external login from Entra ID, already contains a NameIdentifier claim. The format of this claim is not an integer; therefore, int.Parse will throw an error.

I tried changing int.Parse to int.TryParse. This will leave the UserId as null until Umbraco fills the NameIdentifier claim with the correct userID. This fixed the error for Entra ID, but I don’t know if this could cause other issues with other providers.

[github-actions]

Hi there @Oxygen-cl, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[georgebid]

Hey @Oxygen-cl thanks a lot for the PR to fix this issue, someone on the core collaborators team will review this soon 😄

[nikolajlauridsen]

I've had a look at this and it looks good to merge and tests out good as well, for more information see #17383

I've gone ahead and taken the liberty of updating the title for reasons I've mentioned in #17383